Mark compiler-outlined functions in AST#36168
Mark compiler-outlined functions in AST#36168anchmelev wants to merge 2 commits intofacebook:mainfrom
Conversation
|
Hi @anchmelev! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
1 participant
Summary
Add an AST marker to function declarations emitted by function outlining so downstream Babel passes can distinguish compiler-generated helpers from user-authored top-level functions.
This is intended to support integrations such as Reanimated/worklets, where a helper that originally lived inside a worklet callback may be outlined by React Compiler and still needs to be recognized as compiler-generated in later passes.
The generated JavaScript is unchanged; this only annotates outlined
FunctionDeclarationnodes withisOutlinedByReactCompiler.Fixes #32580.
How did you test this change?
enableFunctionOutliningbreaksreact-native-reanimatedAPI callbacks #32580:useDerivedValue(() => [1, 2, 3].map(() => null))yarn jestincompiler/packages/babel-plugin-react-compilerenv -u NO_COLOR yarn testyarn lintand fixed the reported multiline comment style issue